Compare cached cache size with current request #823
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
approved these changes
Feb 14, 2025
Contributor
|
Thanks @deividasstr . Can you fix up that test? |
Contributor
Author
Sure, but after this PR is merged - it simplifies the storate calculation logic. |
Contributor
Author
|
This PR removes max file size caching, thus rendering this PR obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if developer changes cache size, the users who have cache, will not have their cache size reduced (until some cache clear).
This might be harmful for when the cache change is made due to memory issue (too little cache was set initially, or too much)
The change simply compares caches cache size vs requested.
There could be one case when recalculation of cache size will still happen - when cached cache size was not different from requested, but the requested cache size was more than available space at that time (so available space size was cached instead). But it does not sound like a very important case.